Changeset 101 for java/main/src/main/java/com/framsticks/gui/ObjectPanel.java

Timestamp:

07/14/13 23:20:04 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• improve tree side notes
• improve GUI layout
• add foldable list of occured events to EventControl?
• improve automatic type conversion in proxy listeners
• implement several Access functionalities as algorithms independent of Access type
• introduce draft base classes for distributed experiments
• automatically register dependant Java classes to FramsClass? registry
• add testing prime experiment and configuration
• simplify and improve task dispatching

CHANGELOG:
Improve task dispatching in RemoteTree?.

GUI no longer hangs on connection problems.

Make all dispatchers joinables.

Refactorize Thread dispatcher.

Remove Task and PeriodicTask?.

Use Java utilities in those situations.

Reworking tasks dispatching.

Fix bug in EventControl? listener dispatching.

Minor improvements.

Add testing configuration for ExternalProcess? in GUI.

More improvement to prime.

Support for USERREADONLY in GUI.

Add that flag to various params in Java classes.

Remove redundant register clauses from several FramsClassAnnotations?.

Automatically gather and register dependant classes.

Add configuration for prime.

Improve Simulator class.

Add prime.xml configuration.

Introduce draft Experiment and Simulator classes.

Add prime experiment tests.

Enclose typical map with listeners into SimpleUniqueList?.

Needfile works in GUI.

Improve needfile handling in Browser.

More improvement with NeedFile?.

Implementing needfile.

Update test.

Rename ChangeEvent? to TestChangeEvent?.

Automatic argument type search in RemoteTree? listeners.

MultiParamLoader? uses AccessProvider?. By default old implementation
enclosed in AccessStash? or Registry.

Minor changes.

Rename SourceInterface? to Source.

Also improve toString of File and ListSource?.

Remove unused SimpleSource? class.

Add clearing in HistoryControl?.

Show entries in table at EventControl?.

Improve EventControl?.

Add listeners registration to EventControl?.

Add foldable table to HistoryControl?.

Add control row to Procedure and Event controls.

Improve layout of controls.

Another minor change to gui layout.

Minor improvement in the SliderControl?.

Minor changes.

Move ReflectionAccess?.Backend to separate file.

It was to cluttered.

Cleanup in ReflectionAccess?.

Move setMin, setMax, setDef to AccessOperations?.

Extract loading operation into AccessOperations?.

Append Framsticks to name of UnsupportedOperationException?.

The java.lang.UnsupportedOperationException? was shadowing this class.

Rename params.Util to params.ParamsUtil?.

Several improvements.

• Merge ValueControlListener? into ControlOwner?.
• Remove several deprecated utility classes.
• Add EventListeners? utility container.

Minor changes.

Implement revert functionality.

Improve local changes management.

Minor improvement.

Remove methods rendered superfluous after SideNoteKey? improvement.

Improve SideNoteKey?.

It is now generic type, so explicit type specification at
call site is no more needed.

Introduce SideNoteKey? interface.

Only Objects implementing that key may be used as side note keys.

Minor improvements.

Use strings instead of ValueControls? in several gui mappings.

File:

• java/main/src/main/java/com/framsticks/gui/ObjectPanel.java (modified) (8 diffs)

java/main/src/main/java/com/framsticks/gui/ObjectPanel.java

@@ -5 +5 @@
 import com.framsticks.gui.controls.ControlOwner;
 import com.framsticks.gui.controls.ValueControl;
-import com.framsticks.gui.controls.ValueControlListener;
 import com.framsticks.params.Access;
 import com.framsticks.params.Param;
-import com.framsticks.params.ValueParam;
 
 import org.apache.logging.log4j.Logger;
@@ -16 +14 @@
 
 import java.util.Collection;
-import java.util.IdentityHashMap;
+import java.util.HashMap;
 import java.util.Map;
 import static com.framsticks.util.lang.Containers.filterInstanceof;
 
 import com.framsticks.util.FramsticksException;
+
+import static com.framsticks.core.TreeOperations.*;
 
 @SuppressWarnings("serial")
@@ -27 +27 @@
         private static final Logger log = LogManager.getLogger(ObjectPanel.class);
 
-        final protected Map<Param, Control> components = new IdentityHashMap<Param, Control>();
-        final protected Map<ValueParam, ValueControl> valueControls = new IdentityHashMap<ValueParam, ValueControl>();
+        final protected Map<String, Control> controls = new HashMap<String, Control>();
+        final protected Map<String, ValueControl> valueControls = new HashMap<String, ValueControl>();
 
         protected final JPanel contentPanel;
@@ -38 +38 @@
                 contentPanel = new JPanel();
                 scrollPane = new JScrollPane(contentPanel);
-                contentPanel.setLayout(new BoxLayout(contentPanel, BoxLayout.PAGE_AXIS));
+
                 setupContentComponent(scrollPane);
 
-                Gui.fillWithControls(this, params, components, Control.class);
+                Gui.fillWithControls(this, contentPanel, params, controls, Control.class);
                 setName(framsClass.getId());
 
-                for (final ValueControl c : filterInstanceof(components.values(), ValueControl.class)) {
-                        valueControls.put(c.getParam(), c);
+                for (final ValueControl c : filterInstanceof(controls.values(), ValueControl.class)) {
+                        valueControls.put(c.getParam().getId(), c);
                         c.setUserEnabled(true);
-                        c.setListener(new ValueControlListener() {
-                                @Override
-                                public boolean onChange(Object newValue) {
-                                        if (currentPath == null) {
-                                                return true;
-                                        }
-                                        boolean result = treeAtFrame.changeValue(currentPath.assureResolved().getTopObject(), c, newValue);
-                                        refreshControlButtons();
-                                        return result;
-                                }
-                        });
                 }
 
@@ -68 +57 @@
                 assert frame.isActive();
                 assert currentPath != null;
-                treeAtFrame.pushLocalChanges(currentPath);
+                treeAtFrame.pushUserChangesToTree(currentPath);
+                refreshControlButtons();
         }
 
-        protected void refreshControlButtons() {
-                assert frame.isActive();
-                applyButton.setEnabled(treeAtFrame.hasLocalChanges(currentPath.getTopObject()));
+
+        @Override
+        protected void revertChanges() {
+                assert currentPath != null;
+                removeSideNote(currentPath, treeAtFrame.getUserChangesKey());
+                pullValuesFromLocalToUser(bindAccess(currentPath));
         }
 
@@ -81 +74 @@
                 log.debug("refreshing components");
 
-                final Map<ValueControl, Object> values = new IdentityHashMap<ValueControl, Object>();
-                for (Map.Entry<ValueParam, ValueControl> e : valueControls.entrySet()) {
-                        values.put(e.getValue(), access.get(e.getKey().getId(), Object.class));
+                UserChanges userChanges = getSideNote(currentPath, treeAtFrame.getUserChangesKey());
+
+
+                for (Map.Entry<String, ValueControl> e : valueControls.entrySet()) {
+                        String id = e.getKey();
+                        Object value;
+                        if (userChanges != null && userChanges.changes.containsKey(id)) {
+                                value = userChanges.changes.get(id);
+                        } else {
+                                value = access.get(id, Object.class);
+                        }
+
+                        e.getValue().pushValueToUserInterface(value);
                 }
 
-
-                NodeAtFrame nodeAtFrame = treeAtFrame.getLocalInfo(currentPath.getTopObject());
-                if (nodeAtFrame != null) {
-                        for (Map.Entry<ValueControl, Object> e : nodeAtFrame.localChanges.entrySet()) {
-                                values.put(e.getKey(), e.getValue());
-                        }
+                for (Map.Entry<String, Control> e : controls.entrySet()) {
+                        e.getValue().refreshState();
                 }
 
-                for (Map.Entry<ValueControl, Object> e : values.entrySet()) {
-                        e.getKey().pushValueToUserInterface(e.getValue());
-                }
                 refreshControlButtons();
-                ObjectPanel.this.revalidate();
-
+                // ObjectPanel.this.revalidate();
         }
 
@@ -105 +100 @@
         public String getTitle() {
                 return "Properties";
-        }
-
-        @Override
-        public JPanel getPanelForControls() {
-                return contentPanel;
         }
 
@@ -122 +112 @@
         }
 
+        @Override
+        public boolean onValueChange(ValueControl control, Object newValue) {
+                if (currentPath == null) {
+                        return true;
+                }
+                boolean result = treeAtFrame.changeValue(currentPath.assureResolved().getTopObject(), control, newValue);
+                refreshControlButtons();
+                return result;
+        }
+
 }