Changeset 87 for java/main/src/main/java/com/framsticks/params/PrimitiveParam.java

Timestamp:

06/28/13 11:56:03 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• FramsClass? and contained Param are now immutable classes (like String),

which allows to refer to them concurrently without synchronization
(which for example in turn simplifies GUI management)

• also make Path immutable (which was earlier only assumed)
• add global cache for FramsClasses? created solely and automatically

on base of Java classes.

• add global cache for ReflectionAccess?.Backend precomputed proxy

representations basing on given FramsClass?

• above changes greatly improved GUI responsivness during browsing
• furtherly improve Param class hierarchy
• allow to inject actions on state changes into MultiParamLoader?
• add more tests

CHANGELOG:

Add StatusListener? to MultiParamLoader?.

Minor refactorization in MultiParamLoader?.

First step with auto append.

Add SchemaTest?.

Improve Registry.

Clean up in Registry.

Work out Registry.

Use annotations for Param.

Fix ListChange?.

Improve fluent interface of the FramsClassBuilder?.

Done caching of ReflectionAccess?.Backend

Fix hashCode of Pair.

A step on a way to cache ReflectionAccess?.Backend

Make SimpleAbstractAccess?.framsClass a final field.

Add static cache for FramsClasses? based on java.

Only classes created strictly and automatically
based on java classes are using this cache.

Make all Params immutable.

Many improvement to make Param immutable.

Make PrimitiveParam? generic type.

Several changes to make Param immutable.

Make FramsClass? immutable.

Another improvement to Path immutability.

Several improvements to Path.

Improve PathTest?.

Configurarable MutabilityDetector?.

File:

• java/main/src/main/java/com/framsticks/params/PrimitiveParam.java (modified) (3 diffs)

java/main/src/main/java/com/framsticks/params/PrimitiveParam.java

@@ -1 +1 @@
 package com.framsticks.params;
 
+import com.framsticks.util.FramsticksException;
+import com.framsticks.util.lang.Numbers;
+
+import javax.annotation.concurrent.Immutable;
 
 /**
  * @author Piotr Sniegowski
  */
-public abstract class PrimitiveParam extends ValueParam {
+@Immutable
+public abstract class PrimitiveParam<S> extends ValueParam {
 
         /** The minimum allowed value of parameter. */
-        protected Object min;
+        protected final Object min;
 
         /** The maximum allowed value of parameter. */
-        protected Object max;
+        protected final Object max;
 
         /** The default value of parameter. */
-        protected Object def;
+        protected final Object def;
+
+        /**
+         * @param builder
+         */
+        public PrimitiveParam(ParamBuilder builder) {
+                super(builder);
+                min = builder.getMin();
+                max = builder.getMax();
+                def = builder.getDef();
+        }
 
         public void save(SinkInterface sink, Object value) {
@@ -21 +36 @@
 
         protected <T> T tryCastAndReturn(Object value, Class<T> type) {
-                if (value == null)
+                if (value == null) {
                         return null;
+                }
                 try {
-                        return type.cast(value);
+                        if (type.equals(Object.class)) {
+                                return type.cast(value);
+                        }
+                        if (value instanceof String) {
+                                if (type.equals(String.class)) {
+                                        return type.cast(value);
+                                }
+                                // if (Number.class.isAssignableFrom(type)) {
+                                return Numbers.parse((String) value, type);
+                                // }
+                                // return null;
+                        } else {
+                                return type.cast(value);
+                        }
                 } catch (ClassCastException e) {
-                        throw new ClassCastException("property \"" + name
-                                        + "\" type is \"" + value.getClass().getName()
-                                        + "\", not \"" + type.getName() + "\"");
+                        throw new FramsticksException().msg("failed to cast").cause(e).arg("param", this).arg("actual", value.getClass()).arg("requested", type);
                 }
         }
@@ -64 +91 @@
          * @throws ClassCastException the class cast exception, thrown when given getType is incorrect
          */
-        public <T> T getDef(Class<T> type) throws ClassCastException {
+        public <T> T getDef(Class<T> type) {
                 return tryCastAndReturn(def, type);
         }