Changeset 85 for java/main/src/main/java/com/framsticks/util/dispatching/Dispatching.java

Timestamp:

06/24/13 13:38:40 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• upgrade to Java 7
  • use try-multi-catch clauses
  • use try-with-resources were appropriate
• configure FindBugs? (use mvn site and then navigate in browser to the report)
  • remove most bugs found
• parametrize Dispatching environment (Dispatcher, RunAt?) to enforce more control on the place of closures actual call

CHANGELOG:
Rework FavouritesXMLFactory.

FindBugs?. Thread start.

FindBugs?. Minor change.

FindBugs?. Iterate over entrySet.

FindBugs?. Various.

FindBug?.

FindBug?. Encoding.

FindBug?. Final fields.

FindBug?.

Remove synchronization bug in ClientConnection?.

Experiments with findbugs.

Finish parametrization.

Make RunAt? an abstract class.

More changes in parametrization.

More changes in parametrizing dispatching.

Several changes to parametrize tasks.

Rename Runnable to RunAt?.

Add specific framsticks Runnable.

Add JSR305 (annotations).

Add findbugs reporting.

More improvements to ParamBuilder? wording.

Make FramsClass? accept also ParamBuilder?.

Change wording of ParamBuilder?.

Change wording of Request creation.

Use Java 7 exception catch syntax.

Add ScopeEnd? class.

Upgrade to Java 7.

File:

• java/main/src/main/java/com/framsticks/util/dispatching/Dispatching.java (modified) (1 diff)

java/main/src/main/java/com/framsticks/util/dispatching/Dispatching.java

@@ -8 +8 @@
 public abstract class Dispatching {
 
-    public static boolean isThreadSafe() {
-        return true;
-    }
+        public static boolean isThreadSafe() {
+                return true;
+        }
 
-    public static void invokeLaterOrNow(Dispatcher dispatcher, Runnable runnable) {
-        if (dispatcher.isActive()) {
-            runnable.run();
-            return;
-        }
-        dispatcher.invokeLater(runnable);
-    }
+        public static <C> void invokeLaterOrNow(Dispatcher<C> dispatcher, RunAt<? extends C> runnable) {
+                if (dispatcher.isActive()) {
+                        runnable.run();
+                        return;
+                }
+                dispatcher.invokeLater(runnable);
+        }
 
-    public static void dispatchOk(Dispatcher dispatcher, final StateFunctor stateFunctor) {
-        dispatcher.invokeLater(new Runnable() {
-            @Override
-            public void run() {
-                stateFunctor.call(null);
-            }
-        });
-    }
+        //TODO RunAt StateFunctor
+        public static <C> void dispatchOk(Dispatcher<C> dispatcher, final StateFunctor stateFunctor) {
+                dispatcher.invokeLater(new RunAt<C>() {
+                        @Override
+                        public void run() {
+                                stateFunctor.call(null);
+                        }
+                });
+        }
 
-    public static boolean assertInvokeLater(Dispatcher dispatcher, Runnable runnable) {
-        dispatcher.invokeLater(runnable);
-        return true;
-    }
+        // public static boolean assertInvokeLater(Dispatcher dispatcher, RunAt runnable) {
+        //      dispatcher.invokeLater(runnable);
+        //      return true;
+        // }
 
-    public static void invokeDispatch(Dispatcher dispatcher, final Dispatcher finalDispatcher, final Runnable runnable) {
-        dispatcher.invokeLater(new Runnable() {
-            @Override
-            public void run() {
-                finalDispatcher.invokeLater(runnable);
-            }
-        });
-    }
+        public static <P, C> void invokeDispatch(Dispatcher<P> dispatcher, final Dispatcher<C> finalDispatcher, final RunAt<C> runnable) {
+                dispatcher.invokeLater(new RunAt<P>() {
+                        @Override
+                        public void run() {
+                                finalDispatcher.invokeLater(runnable);
+                        }
+                });
+        }
 
 }