Changeset 102 for java/main/src/main/java/com/framsticks/util/dispatching/AbstractJoinable.java

Timestamp:

07/16/13 23:31:35 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• add StackedJoinable? as a utility class to allow strict stack policy

for Joinables running

• add SimulatorConnector?
  • provide Experiment with single Simulator instance
  • checks loaded expdef
• fix bug with sockets closure
• improve task dispatching on startup (BufferedDispatcher?)
• draft Experiment implementation
• add NetLoadSaveLogic?
• add WorkPackageLogic?
• add PrimeExperiment? experiment class

CHANGELOG:
Add WorkPackageLogic? and classes representing prime experiment state.

Add classes for PrimeExperiment? state.

Extract single netload routine in Simulator.

Working netload with dummy content in PrimeExperiment?.

More development with NetLoadSaveLogic? and PrimeExperiment?.

Improvement around prime.

Improve BufferedDispatcher?.isActive logic.

Add prime-all.xml configuration.

Manual connecting to existing simulators from GUI.

Guard in SimulatorConnector? against expdef mismatch.

Guard against empty target dispatcher in BufferedDispatcher?.

Make BufferedDispatcher? a Dispatcher (and Joinable).

Minor improvements.

Done StackedJoinable?, improve Experiment.

Develop StackedJoinable?.

Add StackedJoinable? utility joinables controller.

Add dependency on apache-commons-lang.

Add ready ListChange? on Simulators.

Improve hints in ListChange?.

Several improvements.

Found bug with dispatching in Experiment.

Minor improvements.

Fix bug with early finishing Server.

Many changes in Dispatching.

Fix bug with connection.

Do not obfuscate log with socket related exceptions.

Add SocketClosedException?.

Add SimulatorConnector?.

Work out conception of experiment composing of logics building blocks.

Rename SinkInterface? to Sink.

Move saving of Accesses into AccessOperations?.

Some improvements to Experiment.

Improve joinables.

Fix issue with joinables closing.

Add direct and managed consoles to popup menu.

File:

• java/main/src/main/java/com/framsticks/util/dispatching/AbstractJoinable.java (modified) (9 diffs)

java/main/src/main/java/com/framsticks/util/dispatching/AbstractJoinable.java

@@ -18 +18 @@
 
         private static final Logger log = LogManager.getLogger(AbstractJoinable.class);
+        private static final Logger reportLog = LogManager.getLogger(AbstractJoinable.class.getName() + ".Report");
 
         protected final Set<JoinableParent> owners = new HashSet<JoinableParent>();
@@ -35 +36 @@
         }
 
+
+
         public static void report() {
+                if (!reportLog.isDebugEnabled()) {
+                        return;
+                }
                 StringBuilder b = new StringBuilder();
                 synchronized (joinablesRegistry) {
@@ -42 +48 @@
                         }
                 }
-                log.debug("state: {}", b);
+                reportLog.debug("state: {}", b);
         }
 
@@ -53 +59 @@
                 }
                 this.state = state;
-
-                log.debug("{} is notifying {} parents", this, joinableListeners.size());
+                log.debug("{} changed state to {}", this, state);
+
 
                 List<JoinableParent> parents = new LinkedList<>();
@@ -61 +67 @@
                 for (JoinableParent p : parents) {
                         if (p != null) {
+                                log.debug("{} is notifying parent {} about change to {}", this, p, state);
                                 Dispatching.childChangedState(p, this, state);
                         }
@@ -110 +117 @@
                 }
                 joinableJoin();
-                synchronized (this) {
-                        this.state = JoinableState.JOINED;
-                }
+                changeState(JoinableState.JOINED);
+                // synchronized (this) {
+                //      this.state = JoinableState.JOINED;
+                // }
         }
 
@@ -158 +166 @@
                 synchronized (this) {
                         if (!owners.contains(owner)) {
-                                return false;
-                                // throw new FramsticksException().msg("object is not owning that joinable").arg("joinable", this).arg("object", owner);
+                                // log.error("owner {} is not owning that joinable {}", owner, this);
+                                // return false;
+                                throw new FramsticksException().msg("object is not owning that joinable").arg("joinable", this).arg("object", owner);
                         }
                         // assert owners.containsKey(owner);
-                        log.debug("{} is droping {}", owner, this);
                         owners.remove(owner);
                         stop = owners.isEmpty();
+                        log.debug("{} is droping {} (users remaining: {})", owner, this, owners);
                 }
                 if (stop) {
@@ -195 +204 @@
         @Override
         public String toString() {
-                return getName();
+                return getClass().getSimpleName() + "(" + getName() + ")";
         }
 
@@ -203 +212 @@
         }
 
-
 }