Opened 7 years ago
Last modified 7 years ago
#62 closed defect
Multiple issues with f4 to fix each one independently, discuss when needed — at Version 3
Reported by: | Maciej Komosinski | Owned by: | Grzegorz Latosiński |
---|---|---|---|
Priority: | major | Milestone: | |
Component: | genetic representations | Version: | |
Keywords: | Cc: |
Description (last modified by )
- add f4 tests with invalid genotypes (to test problematic parsing, valgrind)
- add f1 tests to see if introducing GeneProps? did not change the calculation of properties (and detect the 'm' bug!)
- implement approximate, fast, very low and constant complexity coloring in f4 (styles) just like it is done in f1
- oper_f4.cpp:137 maybe move all modifier definitions to one location
- oper_f4.cpp:178 address this TODO
- f4_general.cpp:478 address this TODO
- "default move control to neuclasshandler" unclear meaning
- same: "error: if no previous"
- same: "Need to check if exists"
- same:
//they belong to neurons
- same: "tc3 is only to ensure that in the end of neuron parameter definition"
- check:
sprintf((char*)buf2.c_str(), "%d", i1);
and all other similar use cases - makeNull() never used?
- char count; repetition counter - TODO discuss the CHAR type
- f4_general.h from line 160 upwards. Fix English, merge (remove spaces) * (pointer) with variable names or type names when there is no variable name
- unify modifier macros between f1 and f4?
- still true?
#define F4_MODIFIERS_VISUAL "" //not supported in f4
- fix Geno_f4::style, old pieces of code remain and clash with new
- still needed?
double state; ///<state of neuron double inertia; ///<inertia of neuron double force; ///<force of neuron double sigmo; ///<sigmoid of neuron
- out of line comment?
// a collection of cells, like Organism, for developmental encoding
and another
// convert f4 geno string to tree structure (internal)
- unclear in parentheses:
@return 0 if repair can be performed, -1 otherwise (the repair flag wasn't set in constructor)
- int min, int max -> int mn, int mx
@param current parent of the analysed branch of the genotype
- there is no "current" arg?- notation everywhere:
double * v -> double *v const char * parse() -> const char* parse()
Change History (3)
comment:1 Changed 7 years ago by
comment:2 Changed 7 years ago by
Description: | modified (diff) |
---|
comment:3 Changed 7 years ago by
Description: | modified (diff) |
---|
Restored the full list of (fixed earlier) issues, for documentation purposes
Note: See
TracTickets for help on using
tickets.
In 767: