Changeset 97 for java/main/src/main/java/com/framsticks/communication/Subscription.java

Timestamp:

07/06/13 03:51:11 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• add proper exception passing between communication sides:

if exception occur during handling client request, it is
automatically passed as comment to error response.

• unify various functors into Future<T>
• add FutureHandler?<T> using passed ExceptionHandler?
• organize Connections functionalities in more granular way
• add TrackConsole?

it may be used to snoop communication between peers

• fix algorithm choosing text controls in GUI
• allow GUI testing in virtual frame buffer (xvfb)

FEST had some problem with xvfb but workaround was found

• add StatusBar? to show handled exceptions
• add DirectConsole? to communicate with server by hand

supports tab-completion based on requests history

CHANGELOG:
Further improve handling of exceptions in GUI.

Add StatusBar? implementing ExceptionResultHandler?.

Make completion processing asynchronous.

Minor changes.

Improve completion in console.

Improve history in InteractiveConsole?.

First working version of DirectConsole?.

Minor changes.

Make Connection.address non final.

It is more suitable to use in configuration.

Improvement of consoles.

Improve PopupMenu? and closing of FrameJoinable?.

Fix BrowserTest?.

Found bug with FEST running under xvfb.

JButtonFixture.click() is not working under xvfb.
GuiTest? has wrapper which uses JButton.doClick() directly.

Store CompositeParam? param in TreeNode?.

Simplify ClientSideManagedConnection? connecting.

There is now connectedFunctor needed, ApplicationRequests? can be
send right after creation. They are buffered until the version
and features are negotiated.

Narow down interface of ClientSideManagedConnection?.

Allow that connection specialization send only
ApplicationRequests?.

Improve policy of text control choosing.

Change name of Genotype in BrowserTest?.

Make BrowserTest? change name of Genotype.

Minor change.

First working draft of TrackConsole?.

Simplify Consoles.

More improvements with gui joinables.

Unify initialization on gui joinables.

More rework of Frame based entities.

Refactorize structure of JFrames based entities.

Extract GuiTest? from BrowserBaseTest?.

Reorganize Console classes structure.

Add Collection view to JoinableCollection?.

Configure timeout in testing.

Minor changes.

Rework connections hierarchy.

Add Mode to the get operation.

Make get and set in Tree take PrimitiveParam?.

Unify naming of operations.

Make RunAt? use the given ExceptionHandler?.

It wraps the virtual runAt() method call with
try-catch passing exception to handler.

Force RunAt? to include ExceptionHandler?.

Improve ClientAtServer?.

Minor change.

Another sweep with FindBugs?.

Rename Instance to Tree.

Minor changes.

Minor changes.

Further clarify semantics of Futures.

Add FutureHandler?.

FutureHandler? is refinement of Future, that proxifies
exception handling to ExceptionResultHandler? given
at construction time.

Remove StateFunctor? (use Future<Void> instead).

Make Connection use Future<Void>.

Unparametrize *ResponseFuture?.

Remove StateCallback? not needed anymore.

Distinguish between sides of ResponseFuture?.

Base ResponseCallback? on Future (now ResponseFuture?).

Make asynchronous store taking Future for flags.

Implement storeValue in ObjectInstance?.

File:

• java/main/src/main/java/com/framsticks/communication/Subscription.java (modified) (5 diffs)

java/main/src/main/java/com/framsticks/communication/Subscription.java

@@ -4 +4 @@
 
 import com.framsticks.communication.queries.RegistrationRequest;
+import com.framsticks.util.dispatching.AtOnceDispatcher;
 import com.framsticks.util.dispatching.Dispatcher;
 import com.framsticks.util.dispatching.Dispatching;
 import com.framsticks.util.dispatching.RunAt;
-import com.framsticks.util.FramsticksException;
-import com.framsticks.util.StateFunctor;
+import com.framsticks.util.dispatching.ThrowExceptionHandler;
+
 import org.apache.log4j.Logger;
 
@@ -19 +20 @@
         private final static Logger log = Logger.getLogger(Subscription.class);
 
-        private final ClientConnection connection;
+        private final ClientSideManagedConnection connection;
         private final String path;
         private final String registeredPath;
@@ -26 +27 @@
         private EventCallback eventCallback;
 
-        public Subscription(ClientConnection connection, String path, String registeredPath, Dispatcher<C> dispatcher) {
+        public Subscription(ClientSideManagedConnection connection, String path, String registeredPath, Dispatcher<C> dispatcher) {
                 this.connection = connection;
                 this.path = path;
@@ -46 +47 @@
         }
 
-        public void unsubscribe(final StateFunctor stateFunctor) {
+        public void unsubscribe(final ClientSideResponseFuture future) {
                 //@todo remove that /cli/ prefix, when registeredPath will be a fully qualified path
-                connection.send(new RegistrationRequest().register(false).path(registeredPath), new ResponseCallback<Connection>() {
+                connection.send(new RegistrationRequest().register(false).path(registeredPath), AtOnceDispatcher.getInstance(), new ClientSideResponseFuture(future) {
+
                         @Override
-                        public void process(Response response) {
-                                if (!response.getOk()) {
-                                        log.error("failed to unsunscribe " + this + ": " + response.getComment());
-                                        stateFunctor.handle(new FramsticksException().msg("unsubscription failed").arg("comment", response.getComment()));
-                                        return;
-                                }
+                        protected void processOk(Response response) {
                                 assert response.hasFiles();
                                 log.debug("unsunscribed " + this);
-                                stateFunctor.call();
+                                future.pass(response);
                         }
                 });
@@ -76 +73 @@
 
         public void dispatchCall(final List<File> files) {
-                Dispatching.dispatchIfNotActive(dispatcher, new RunAt<C>() {
+                //TODO TEH
+                Dispatching.dispatchIfNotActive(dispatcher, new RunAt<C>(ThrowExceptionHandler.getInstance()) {
                         @Override
-                        public void run() {
+                        protected void runAt() {
                                 eventCallback.call(files);
                         }