Changeset 85 for java/main/src/main/java/com/framsticks/params/ReflectionAccess.java

Timestamp:

06/24/13 13:38:40 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• upgrade to Java 7
  • use try-multi-catch clauses
  • use try-with-resources were appropriate
• configure FindBugs? (use mvn site and then navigate in browser to the report)
  • remove most bugs found
• parametrize Dispatching environment (Dispatcher, RunAt?) to enforce more control on the place of closures actual call

CHANGELOG:
Rework FavouritesXMLFactory.

FindBugs?. Thread start.

FindBugs?. Minor change.

FindBugs?. Iterate over entrySet.

FindBugs?. Various.

FindBug?.

FindBug?. Encoding.

FindBug?. Final fields.

FindBug?.

Remove synchronization bug in ClientConnection?.

Experiments with findbugs.

Finish parametrization.

Make RunAt? an abstract class.

More changes in parametrization.

More changes in parametrizing dispatching.

Several changes to parametrize tasks.

Rename Runnable to RunAt?.

Add specific framsticks Runnable.

Add JSR305 (annotations).

Add findbugs reporting.

More improvements to ParamBuilder? wording.

Make FramsClass? accept also ParamBuilder?.

Change wording of ParamBuilder?.

Change wording of Request creation.

Use Java 7 exception catch syntax.

Add ScopeEnd? class.

Upgrade to Java 7.

File:

• java/main/src/main/java/com/framsticks/params/ReflectionAccess.java (modified) (3 diffs)

java/main/src/main/java/com/framsticks/params/ReflectionAccess.java

@@ -47 +47 @@
                         try {
                                 return type.cast(reflectedClass.getMethod(accessorName(true, id)).invoke(object));
-                        } catch (NoSuchMethodException ex) {
-                                //ex.printStackTrace();
-                        } catch (InvocationTargetException e) {
+                        } catch (NoSuchMethodException | InvocationTargetException ex) {
+                                //e.printStackTrace();
+                        }
+                        try {
+                                return type.cast(reflectedClass.getMethod(id).invoke(object));
+                        } catch (NoSuchMethodException | InvocationTargetException ex) {
                                 //e.printStackTrace();
                         }
 
-                } catch (IllegalAccessException ex) {
+                } catch (IllegalAccessException e) {
                         log.warn("illegal access error occurred while trying to access returnedObject");
-                        ex.printStackTrace();
+                        e.printStackTrace();
                 } catch (ClassCastException ignored) {
 
@@ -87 +90 @@
                         try {
                                 reflectedClass.getMethod(accessorName(false, id), new Class[]{param.getStorageType()}).invoke(object, value);
-                        } catch (InvocationTargetException ignored) {
-                        } catch (NoSuchMethodException ignored) {
+                        } catch (InvocationTargetException | NoSuchMethodException ignored) {
+                        }
+                        try {
+                                reflectedClass.getMethod(id, new Class[]{param.getStorageType()}).invoke(object, value);
+                        } catch (InvocationTargetException | NoSuchMethodException ignored) {
                         }
                 } catch (Exception ex) {
@@ -161 +167 @@
                 try {
                         return reflectedClass.newInstance();
-                } catch (InstantiationException e) {
-                        e.printStackTrace();
-                } catch (IllegalAccessException e) {
+                } catch (InstantiationException | IllegalAccessException e) {
                         e.printStackTrace();
                 }