Changeset 676 for cpp

Timestamp:

08/26/17 03:05:37 (7 years ago)

Author:

Maciej Komosinski

Message:

Improved comments, removed unnecessary TODO regarding "Rr" modifiers

File:

• cpp/frams/genetics/f4/oper_f4.cpp (modified) (2 diffs)

cpp/frams/genetics/f4/oper_f4.cpp

@@ -18 +18 @@
 //see also modifiers in f1
 #define F4_MODIFIERS_VISUAL "" //not supported in f4
-#define F4_MODIFIERS_RARE "EeWwAaSs" //expdef would need to handle these properly/specifically to ensure reasonable behavior, and hardly any expdef does. Modifying initial energy of a creature as a result of its genes (Ee) is in general not a good idea. Weight (Ww) works only in water, and there sinking/going up should usually be caused by real activity of a creature, not by its inherited weight. For assimilation (Aa) , there is a dedicated parameter in CreaturesGroup. Stamina (Ss) is no longer needed as destructive collisions are not supported, and even if they were, some expdef would need to impose reasonable restrictions on the value of this parameter (e.g. similar to normalizeBiol4()) and the specific consequences of destructions should be defined as needed.
-#define F4_MODIFIERS "LlRrCcQqFfMmIi" F4_MODIFIERS_RARE F4_MODIFIERS_VISUAL //TODO no Rr in f4?
+#define F4_MODIFIERS_RARE "EeWwAaSs" //expdef would need to handle these properly/specifically to ensure reasonable behavior, and hardly any expdef does. Modifying initial energy of a creature as a result of its genes (Ee) is in general not a good idea. Weight (Ww) works only in water, and in water sinking/going up should usually be caused by real "intentional" activity of a creature, not by its inherited weight. For assimilation (Aa), there is a dedicated parameter in CreaturesGroup. Stamina (Ss) is no longer needed as destructive collisions are not supported, and even if they were, some expdef would need to impose reasonable restrictions on the value of this parameter (e.g. similar to normalizeBiol4()) so there is some cost associated with it, and the specific consequences of destructions should be defined as needed.
+#define F4_MODIFIERS "LlRrCcQqFfMmIi" F4_MODIFIERS_RARE F4_MODIFIERS_VISUAL
 const char *Geno_f4::all_modifiers = F4_MODIFIERS;
 
@@ -629 +629 @@
         char ch = g[pos];
         // style categories
-#define STYL4CAT_MODIFIC "LlRrCcQqAaIiSsMmFfWwEe,"
+#define STYL4CAT_MODIFIC F4_MODIFIERS ","
 #define STYL4CAT_NEUMOD "[]|@*GTS:+-/!="
 #define STYL4CAT_DIGIT "0123456789."