Changeset 658 for cpp/frams/model/geometry/modelgeometryinfo.cpp

Timestamp:

04/24/17 03:14:21 (6 years ago)

Author:

Maciej Komosinski

Message:

• One function name made shorter
• Fixed some typos
• Predictable behavior for empty (zero-Part) Models (that should never happen)

File:

• cpp/frams/model/geometry/modelgeometryinfo.cpp (modified) (3 diffs)

cpp/frams/model/geometry/modelgeometryinfo.cpp

@@ -7 +7 @@
 #include <frams/model/geometry/meshbuilder.h>
 
-void ModelGeometryInfo::findSizesAndAxesOfModel(const Model &input_model, const double density,
+void ModelGeometryInfo::findSizesAndAxes(const Model &input_model, const double density,
         Pt3D &sizes, Orient &axes)
 {
@@ -25 +25 @@
 }
 
-bool ModelGeometryInfo::boundingBox(const Model &model, Pt3D &lowerBoundary, Pt3D &upperBoundary)
+void ModelGeometryInfo::boundingBox(const Model &model, Pt3D &lowerBoundary, Pt3D &upperBoundary)
 {
-        if (model.getPartCount() == 0)
+        if (model.getPartCount() == 0) //should never happen. Invalid model provided?
         {
-                return false;
+                lowerBoundary = Pt3D_0;
+                upperBoundary = Pt3D_0;
+                return;
         }
         
@@ -42 +44 @@
                 upperBoundary.getMax(partUpperBoundary);
         }
-        
-        return true;
 }