Changeset 657 for cpp/frams

Timestamp:

04/24/17 03:10:51 (8 years ago)

Author:

Maciej Komosinski

Message:

A comment on potential optimization in ModelGeometryInfo?

File:

• cpp/frams/model/geometry/modelgeometryinfo.h (modified) (1 diff)

cpp/frams/model/geometry/modelgeometryinfo.h

@@ -10 +10 @@
 #include <frams/util/list.h>
 
+
+/**
+Currently, the three functions area(), volume() and findSizesAndAxes() are independent and self-sufficient.
+Each of them converts the input model to SolidsShapeTypeModel if necessary.
+Were these functions to be called multiple times for the same model, this would be inefficient
+(the potential conversion of the same model would take place multiple times).
+
+To improve efficiency, these functions should not have the Model argument.
+Instead, another function should be introduced to set the model, the conversion to SolidsShapeTypeModel
+should take place in this function once, and these three functions would then always use the converted model.
+A similar optimization is already implemented in the ModelGeometry class that provides FramScript access to ModelGeometryInfo.
+*/
 namespace ModelGeometryInfo
 {
-        void findSizesAndAxesOfModel(const Model &model, const double density, Pt3D &sizes,
-                Orient &axes);
-        bool boundingBox(const Model &model, Pt3D &lowerBoundary, Pt3D &upperBoundary);
+        double area(const Model &model, const double density);
+        double volume(const Model &model, const double density);
+        void findSizesAndAxes(const Model &model, const double density, Pt3D &sizes, Orient &axes);
+
+        void boundingBox(const Model &model, Pt3D &lowerBoundary, Pt3D &upperBoundary);
         void boundingBox(const Part *part, Pt3D &lowerBoundary, Pt3D &upperBoundary);
-        double volume(const Model &model, const double density);
-        double area(const Model &model, const double density);
         double externalAreaOfPart(const Model &model, const int partIndex, const double density);
         double externalAreaOfEllipsoid(const Model &model, const int partIndex, const double density);