Changeset 284

Timestamp:

01/05/15 20:39:39 (10 years ago)

Author:

Maciej Komosinski

Message:

Wrong sscanf size in 64-bit caused stack damage (in "0x....." conversion)

Location:

cpp/frams

Files:

• param/param.h (modified) (1 diff)
• util/extvalue.cpp (modified) (2 diffs)

cpp/frams/param/param.h

@@ -36 +36 @@
 typedef int32_t paInt;
 #define PA_INT_SCANF "%d"
+#define PA_INT_SCANF_X "%x"
 
 // the result of param::set() is a combination of bits:

cpp/frams/util/extvalue.cpp

@@ -614 +614 @@
         {
         paInt val;
-        sscanf(s+2,"%lx",&val);
+        sscanf(s+2,PA_INT_SCANF_X,&val);
         return val;
         }
@@ -631 +631 @@
         {
         paInt val;
-        sscanf(s+2,"%lx",&val);
+        sscanf(s+2,PA_INT_SCANF_X,&val);
         return val;
         }