Changeset 1322

Timestamp:

08/09/24 05:33:09 (3 months ago)

Author:

Maciej Komosinski

Message:

Use libm.so when available to disable exceptions in pyemd, and if not (e.g., on Windows), proceed without it

File:

• framspy/dissimilarity/density_distribution.py (modified) (3 diffs)

framspy/dissimilarity/density_distribution.py

@@ -9 +9 @@
     """
 
-    OLD_FPEX = False # update floating point exception handling/pyemd problems (if still needed) for new python versions
-    if OLD_FPEX:
-        libm = cdll.LoadLibrary(find_library('m')) # for disabling/enabling floating point exceptions (division by zero occurs in the EMD library)
+    libm = find_library('m')  # for disabling/enabling floating point exceptions (division by zero occurs in the pyemd library)
+    if libm is not None:  # libm.so (the mathematical library) is a part of Linux ecosystem - always present
+        libm = cdll.LoadLibrary(libm)
+    else:
+        print('\nWarning: The "m" library not found - floating point exceptions in pyemd may occur...\n') # but on Windows, pyemd does not seem to cause floating point exceptions
     EPSILON = 0.0001
     
@@ -293 +295 @@
                 dist_matrix = self.calculateDistanceMatrix(s1[0],s2[0])
 
-            if self.OLD_FPEX:
-                self.libm.fedisableexcept(0x04)  # change default flag value - don't cause exceptions when dividing by 0 (pyemd does it)
+            if self.libm is not None:
+                self.libm.fedisableexcept(0x04)  # change default flag value - don't cause "Floating point exception" when dividing by 0 (pyemd does that, for example when comparing two identical histograms, i.e., two identical signatures, for example from two identical phenotypes)
 
             if self.frequency:
@@ -301 +303 @@
                 out = emd(self.normalize(s1[1]),self.normalize(s2[1]),dist_matrix)
 
-            if self.OLD_FPEX:
-                self.libm.feclearexcept(0x04) # restoring default flag values...
+            if self.libm is not None:
+                self.libm.feclearexcept(0x04)  # restoring default flag values...
                 self.libm.feenableexcept(0x04)