Changeset 1200 for framspy

Timestamp:

02/06/23 20:29:12 (22 months ago)

Author:

Maciej Komosinski

Message:

Make errors during evaluation of creatures Python exceptions so they are more noticeable and consequential

File:

• framspy/FramsticksLib.py (modified) (5 diffs)

framspy/FramsticksLib.py

@@ -32 +32 @@
 
 
-        # This function is not needed because in python, "For efficiency reasons, each module is only imported once per interpreter session."
+        # This function is not needed because in Python, "For efficiency reasons, each module is only imported once per interpreter session."
         # @staticmethod
         # def getFramsModuleInstance():
@@ -60 +60 @@
                 frams.Simulator.expdef = "standard-eval"  # this expdef (or fully compatible) must be used by EVALUATION_SETTINGS_FILE
                 if sim_settings_files is not None:
-                        self.EVALUATION_SETTINGS_FILE = sim_settings_files
+                        self.EVALUATION_SETTINGS_FILE = sim_settings_files # overwrite defaults
                 print('Using settings:', self.EVALUATION_SETTINGS_FILE)
                 assert isinstance(self.EVALUATION_SETTINGS_FILE, list)  # ensure settings file(s) are provided as a list
@@ -71 +71 @@
                         print(ec.messages) # output all caught messages
                         if ec.error_count._value() > 0:
-                                raise ValueError("Problem while importing file '%s'" % simfile) # make missing files or incorrect paths fatal because they would not stop Framsticks from further processing, and error messages are easy to overlook in output 
+                                raise ValueError("Problem while importing file '%s'" % simfile) # make missing files or incorrect paths fatal because error messages are easy to overlook in output, and these errors would not prevent Framsticks simulator from performing genetic operations, starting and running in evaluate()
 
 
@@ -89 +89 @@
                 if not self.PRINT_FRAMSTICKS_OUTPUT:
                         ec = frams.MessageCatcher.new()  # mute potential errors, warnings, messages
+                        ec.store = 2; # store all, because they are caught by MessageCatcher and will not appear on console
 
                 frams.GenePools[0].clear()
@@ -107 +108 @@
 
                 if not self.PRINT_FRAMSTICKS_OUTPUT:
-                        if ec.error_count._value() > 0:  # errors are important and should not be ignored, at least display how many
-                                print("[ERROR]", ec.error_count, "error(s) and", ec.warning_count-ec.error_count, "warning(s) while evaluating", len(genotype_list), "genotype(s)")
                         ec.close()
+                        if ec.error_count._value() > 0:
+                                print(ec.messages) # if errors occurred, output all caught messages for debugging
+                                raise RuntimeError("[ERROR] %d error(s) and %d warning(s) while evaluating %d genotype(s)" % (ec.error_count._value(), ec.warning_count._value()-ec.error_count._value(), len(genotype_list))) # make errors fatal; by default they stop the simulation anyway so let's not use potentially incorrect or partial results and fix the cause first.
 
                 results = []