Changeset 1196

Timestamp:

02/01/23 23:03:50 (2 years ago)

Author:

Maciej Komosinski

Message:

When importing *.sim files, make problems fatal because error messages are easy to overlook in output

File:

• framspy/FramsticksLib.py (modified) (5 diffs)

framspy/FramsticksLib.py

@@ -8 +8 @@
 
 class FramsticksLib:
-        """Communicates directly with Framsticks library (.dll or .so).
+        """Communicates directly with Framsticks library (.dll or .so or .dylib).
         You can perform basic operations like mutation, crossover, and evaluation of genotypes.
         This way you can perform evolution controlled by python as well as access and manipulate genotypes.
@@ -16 +16 @@
         Should you want to modify or extend this class, first see and test the examples in frams-test.py.
 
-        You need to provide one or two parameters when you run this class: the path to Framsticks where .dll/.so resides
-        and, optionally, the name of the Framsticks dll/so (if it is non-standard). See::
+        You need to provide one or two parameters when you run this class: the path to Framsticks where .dll/.so/.dylib resides
+        and, optionally, the name of the Framsticks dll/so/dylib (if it is non-standard). See::
                 FramsticksLib.py -h"""
 
@@ -63 +63 @@
                 print('Using settings:', self.EVALUATION_SETTINGS_FILE)
                 assert isinstance(self.EVALUATION_SETTINGS_FILE, list)  # ensure settings file(s) are provided as a list
+                
                 for simfile in self.EVALUATION_SETTINGS_FILE:
+                        ec = frams.MessageCatcher.new()  # catch potential errors, warnings, messages - just to detect if there are ERRORs
+                        ec.store = 2; # store all, because they are caught by MessageCatcher and will not appear on console (which we want)
                         frams.Simulator.ximport(simfile, 4 + 8 + 16)
+                        ec.close()
+                        print(ec.messages) # output all caught messages
+                        assert ec.error_count._value() == 0, "Problem while importing file '%s'" % simfile # make missing files fatal because error messages are easy to overlook
 
 
@@ -101 +107 @@
                 if not self.PRINT_FRAMSTICKS_OUTPUT:
                         if ec.error_count._value() > 0:  # errors are important and should not be ignored, at least display how many
-                                print("[ERROR]", ec.error_count, "error(s) and", ec.warning_count, "warning(s) while evaluating", len(genotype_list), "genotype(s)")
+                                print("[ERROR]", ec.error_count, "error(s) and", ec.warning_count-ec.error_count, "warning(s) while evaluating", len(genotype_list), "genotype(s)")
                         ec.close()
 
@@ -198 +204 @@
 def parseArguments():
         parser = argparse.ArgumentParser(description='Run this program with "python -u %s" if you want to disable buffering of its output.' % sys.argv[0])
-        parser.add_argument('-path', type=ensureDir, required=True, help='Path to the Framsticks library (.dll or .so) without trailing slash.')
-        parser.add_argument('-lib', required=False, help='Library name. If not given, "frams-objects.dll" or "frams-objects.so" is assumed depending on the platform.')
+        parser.add_argument('-path', type=ensureDir, required=True, help='Path to the Framsticks library (.dll or .so or .dylib) without trailing slash.')
+        parser.add_argument('-lib', required=False, help='Library name. If not given, "frams-objects.dll" (or .so or .dylib) is assumed depending on the platform.')
         parser.add_argument('-simsettings', required=False, help='The name of the .sim file with settings for evaluation, mutation, crossover, and similarity estimation. If not given, "eval-allcriteria.sim" is assumed by default. Must be compatible with the "standard-eval" expdef.')
         parser.add_argument('-genformat', required=False, help='Genetic format for the demo run, for example 4, 9, or S. If not given, f1 is assumed.')