Changeset 1163

Timestamp:

11/29/21 23:28:00 (3 years ago)

Author:

Maciej Komosinski

Message:

Improved diagnostic messages

File:

• framspy/FramsticksEvolution.py (modified) (3 diffs)

framspy/FramsticksEvolution.py

@@ -10 +10 @@
 
 
-def genotype_within_constraint(criterion_actual_value, constraint_value):
+def genotype_within_constraint(genotype, dict_criteria_values, criterion_name, constraint_value):
+        REPORT_CONSTRAINT_VIOLATIONS = False
         if constraint_value is not None:
-                if criterion_actual_value > constraint_value:
+                actual_value = dict_criteria_values[criterion_name]
+                if actual_value > constraint_value:
+                        if REPORT_CONSTRAINT_VIOLATIONS:
+                                print('Genotype "%s" assigned low fitness because it violates constraint "%s": %s exceeds threshold %s' % (genotype, criterion_name, actual_value, constraint_value))
                         return False
         return True
@@ -18 +22 @@
 
 def frams_evaluate(frams_cli, individual):
+        BAD_FITNESS = [-1] * len(OPTIMIZATION_CRITERIA)  # fitness of -1 is intended to discourage further propagation of this genotype via selection ("this genotype is very poor")
         genotype = individual[0]  # individual[0] because we can't (?) have a simple str as a deap genotype/individual, only list of str.
         data = frams_cli.evaluate([genotype])
@@ -29 +34 @@
         except (KeyError, TypeError) as e:  # the evaluation may have failed for an invalid genotype (such as X[@][@] with "Don't simulate genotypes with warnings" option) or for some other reason
                 valid = False
-                print('Error "%s": could not evaluate genotype "%s", returning fitness %s' % (str(e), genotype, fitness))
+                print('Problem "%s" so could not evaluate genotype "%s", hence assigned it low fitness: %s' % (str(e), genotype, BAD_FITNESS))
         if valid:
-                valid &= genotype_within_constraint(default_evaluation_data['numparts'], parsed_args.max_numparts)
-                valid &= genotype_within_constraint(default_evaluation_data['numjoints'], parsed_args.max_numjoints)
-                valid &= genotype_within_constraint(default_evaluation_data['numneurons'], parsed_args.max_numneurons)
-                valid &= genotype_within_constraint(default_evaluation_data['numconnections'], parsed_args.max_numconnections)
-                valid &= genotype_within_constraint(len(genotype), parsed_args.max_numgenochars)
+                default_evaluation_data['numgenocharacters'] = len(genotype)  # for consistent constraint checking below
+                valid &= genotype_within_constraint(genotype, default_evaluation_data, 'numparts', parsed_args.max_numparts)
+                valid &= genotype_within_constraint(genotype, default_evaluation_data, 'numjoints', parsed_args.max_numjoints)
+                valid &= genotype_within_constraint(genotype, default_evaluation_data, 'numneurons', parsed_args.max_numneurons)
+                valid &= genotype_within_constraint(genotype, default_evaluation_data, 'numconnections', parsed_args.max_numconnections)
+                valid &= genotype_within_constraint(genotype, default_evaluation_data, 'numgenocharacters', parsed_args.max_numgenochars)
         if not valid:
-                fitness = [-1] * len(OPTIMIZATION_CRITERIA)  # fitness of -1 is intended to discourage further propagation of this genotype via selection ("this genotype is very poor")
+                fitness = BAD_FITNESS
         return fitness