Changeset 100 for java/main/src/main/java/com/framsticks/gui/TreeAtFrame.java

Timestamp:

07/12/13 23:41:06 (11 years ago)

Author:

psniegowski

Message:

HIGHLIGHTS:

• add <include/> to configuration
• add side notes to tree
  • used to store arbitrary information alongside the tree structure
• migrate to log4j2
  • supports lazy string evaluation of passed arguments
• improve GUI tree
  • it stays in synchronization with actual state (even in high load test scenario)
• improve panel management in GUI
• make loading objects in GUI more lazy
• offload parsing to connection receiver thread
  • info parsing
  • first step of objects parsing
• fix connection parsing bug (eof in long values)
• support zero-arguments procedure in table view

CHANGELOG:
Implement procedure calls from table view.

Refactorization around procedures in tables.

Add table editor for buttons.

Render buttons in the the list view.

Further improve Columns.

Add Column class for TableModel?.

Accept also non-arguments ProcedureParams? in tableView.

Increase maximal TextAreaControl? size.

Add tooltip to ProcedureControl?.

Fix bug of interpreting eofs in long values by connection reader.

Further rework connection parsing.

Simplify client connection processing.

Test ListChange? modification.

Test ListChange? events with java server.

Add TestChild?.

Fix bug with fast deregistering when connecting to running server.

Another minor refactorization in TreeOperations?.

Fix bug in SimpleAbstractAccess? loading routine.

Another minor improvement.

Minor change.

Make reading of List objects two-phase.

Another minor change.

Dispatch parsing into receiver thread.

Another step.

Enclose passing value in ObjectParam? case in closure.

Minor step.

Minor change on way to offload parsing.

Temporarily comment out single ValueParam? get.

It will be generalized to multi ValueParam?.

Process info in receiver thread.

Add DispatchingExceptionHandler?.

Make waits in browser test longer.

Use FETCHED_MARK.

It is honored in GUI, where it used to decide whether to get values

after user action.

It is set in standard algorithm for processing fetched values.

Add remove operation to side notes.

Make loading more lazy.

Improve loading policy.

On node choose load itself, on node expansion, load children.

Minor improvement.

Fix bug with panel interleaving.

Minor improvements.

Improve panel management.

More cleaning around panels.

Reorganize panels.

Further improve tree.

Fix bug in TreeModel?.

Remove children from TreeNode?.

Implement TreeNode? hashCode and equals.

Make TreeNode? delegate equals and hashcode to internal reference.

Move listeners from TreeNode? to side notes.

Store path.textual as a side note.

Side note params instead of accesses for objects.

More refactorizations.

In TreeNode? bindAccess based on side notes.

Minor step.

Hide createAccess.

Rename AccessInterface? to Access.

Minor changes.

Several improvements in high load scenarios.

Change semantics of ArrayListAccess?.set(index, null);

It now removes the element, making list shorter
(it was set to null before).

Add path remove handler.

Handle exceptions in Connection.

Update .gitignore

Configure logging to file.

Move registration to TreeModel?.

Further refactorization.

Minor refactorization.

Minor improvements.

Use specialized event also for Modify action of ListChange?.

Use remove events.

Use the insertion events for tree.

Further improve tree refreshing.

Further improve reacting on events in GUI.

Fix problem with not adding objects on addition list change.

Migrate to log4j lazy String construction interface.

Migrate imports to log4j2.

Drop dependency on adapter to version 1.2.

Switch log4j implementation to log4j2.

Add dirty mark to the NodeAtFrame?.

Make selecting in AccessInterfaces? type safe.

Ignore containers size settings in Model and Genotype.

Use tree side notes to remember local changes and panels.

Add sideNotes to tree.

They will be used to store various accompanying information
right in the tree.

Use ReferenceIdentityMap? from apache in TreeNode?.

It suits the need perfectly (weak semantics on both key and value).

Make ArrayListParam? do not react size changes.

Guard in TableModel? before not yet loaded objects.

Add <include/> clause and AutoInjector?.

Extract common columns configuration to separate xml,
that can be included by other configurations.

File:

• java/main/src/main/java/com/framsticks/gui/TreeAtFrame.java (modified) (8 diffs)

java/main/src/main/java/com/framsticks/gui/TreeAtFrame.java

@@ -1 +1 @@
 package com.framsticks.gui;
 
-import org.apache.log4j.Logger;
+import org.apache.logging.log4j.Logger;
+import org.apache.logging.log4j.LogManager;
 
 import com.framsticks.core.Tree;
@@ -8 +9 @@
 import com.framsticks.core.TreeOperations;
 import com.framsticks.gui.controls.ValueControl;
-import com.framsticks.gui.tree.TreeNode;
 import com.framsticks.params.CompositeParam;
 import com.framsticks.params.FramsClass;
@@ -14 +14 @@
 import java.util.*;
 
-import javax.swing.tree.TreePath;
 
 
 import com.framsticks.util.dispatching.FutureHandler;
-import com.framsticks.util.lang.Casting;
 
 /**
@@ -25 +23 @@
 public class TreeAtFrame {
 
-        private static final Logger log = Logger.getLogger(TreeAtFrame.class);
+        private static final Logger log = LogManager.getLogger(TreeAtFrame.class);
 
         protected final Frame frame;
         protected final Tree tree;
-        protected final Map<String, Panel> knownPanels = new HashMap<String, Panel>();
+        protected final Map<String, TreePanel> knownPanels = new HashMap<>();
         protected Node rootNode;
-
-        protected Map<TreeNode, NodeAtFrame> nodesStorage = new WeakHashMap<>();
 
         public TreeAtFrame(Tree tree, Frame frame) {
@@ -50 +46 @@
         }
 
-        public void registerPanel(Panel panel) {
-        }
-
-        public Panel findPanel(String accessId) {
-                assert frame.isActive();
-                return (knownPanels.containsKey(accessId) ? knownPanels.get(accessId) : null);
-        }
-
         public final String getName() {
                 return tree.getName();
         }
 
-        public Panel preparePanel(CompositeParam param, FramsClass framsClass) {
+        public TreePanel preparePanel(final CompositeParam param) {
                 assert frame.isActive();
-                Panel panel = preparePanelImpl(param, framsClass);
-                assert panel != null;
-                String accessId = param.computeAccessId();
-                panel.uniqueName = accessId + "@" + tree.getName();
-                knownPanels.put(accessId, panel);
-                frame.cardPanel.add(panel, panel.uniqueName);
-                log.debug("prepared panel for " + panel);
-                return panel;
-        }
 
-        protected Panel preparePanelImpl(CompositeParam param, FramsClass framsClass) {
-                assert frame.isActive();
-                List<Panel> panels = new ArrayList<Panel>();
+                TreePanel panel = knownPanels.get(param.getFramsTypeName());
+                if (panel != null) {
+                        return panel;
+                }
 
-                Panel.Parameters parameters = new Panel.Parameters(this, param, framsClass);
+                final FramsClass framsClass = tree.getInfoFromCache(param.getContainedTypeName());
+                final List<TreePanel> panels = new ArrayList<TreePanel>();
+
+                final TreePanel.Parameters parameters = new TreePanel.Parameters(this, param, framsClass);
                 for (PanelProvider pp : frame.browser.panelProviders) {
-                        Panel p = pp.providePanel(parameters);
+                        TreePanel p = pp.providePanel(parameters);
                         if (p != null) {
                                 panels.add(p);
@@ -87 +70 @@
 
                 if (panels.isEmpty()) {
-                        return new EmptyPanel(parameters);
+                        panel = new EmptyTreePanel(parameters);
+                } else  if (panels.size() == 1) {
+                        panel = panels.get(0);
+                } else {
+                        panel = new MultiPanel(parameters, panels);
                 }
-                if (panels.size() == 1) {
-                        return panels.get(0);
-                }
-                return new MultiPanel(parameters, panels);
 
+                knownPanels.put(param.getFramsTypeName(), panel);
+
+                log.debug("prepared panel for {}", panel);
+                return panel;
         }
 
-        public boolean hasLocalChanges(TreePath treePath) {
-                NodeAtFrame nodeAtFrame = nodesStorage.get(treePath.getLastPathComponent());
+
+        public boolean hasLocalChanges(Object object) {
+                NodeAtFrame nodeAtFrame = tree.getSideNote(object, this, NodeAtFrame.class);
                 if (nodeAtFrame == null) {
                         return false;
@@ -104 +92 @@
         }
 
-        public NodeAtFrame assureLocalInfo(TreePath treePath) {
+        public NodeAtFrame assureLocalInfo(Object object) {
                 assert frame.isActive();
-                NodeAtFrame nodeAtFrame = nodesStorage.get(treePath.getLastPathComponent());
+                NodeAtFrame nodeAtFrame = tree.getSideNote(object, this, NodeAtFrame.class);
 
                 if (nodeAtFrame == null) {
                         nodeAtFrame = new NodeAtFrame();
-                        nodesStorage.put(Casting.throwCast(TreeNode.class, treePath.getLastPathComponent()), nodeAtFrame);
+                        // log.debug();
+                        tree.putSideNote(object, this, nodeAtFrame);
                 }
                 return nodeAtFrame;
         }
 
-        public NodeAtFrame getLocalInfo(TreePath treePath) {
-                return nodesStorage.get(treePath.getLastPathComponent());
+        public NodeAtFrame getLocalInfo(Object object) {
+                return tree.getSideNote(object, this, NodeAtFrame.class);
         }
 
-        public boolean changeValue(TreePath treePath, ValueControl component, Object newValue) {
-                log.debug("changing value of " + component + " to '" + newValue + "'");
+        public boolean changeValue(Object object, ValueControl component, Object newValue) {
+                log.debug("changing value of {} to '{}'", component, newValue);
 
-                assureLocalInfo(treePath).localChanges.put(component, newValue);
+                assureLocalInfo(object).localChanges.put(component, newValue);
 
                 return true;
         }
 
-        public void pushLocalChanges(TreePath treePath) {
+        public void pushLocalChanges(Path path) {
                 assert frame.isActive();
+                path.assureResolved();
 
-                NodeAtFrame nodeAtFrame = nodesStorage.get(treePath.getLastPathComponent());
+                NodeAtFrame nodeAtFrame = getLocalInfo(path.getTopObject());
                 if (nodeAtFrame == null) {
                         return;
                 }
-                Path path = frame.treeModel.convertToPath(treePath);
-
                 for (Map.Entry<ValueControl, Object> e : nodeAtFrame.localChanges.entrySet()) {
                         TreeOperations.set(path, e.getKey().getParam(), e.getValue(), new FutureHandler<Integer>(frame) {
@@ -145 +133 @@
         }
 
-        public void fillPanelWithValues(TreePath treePath) {
-                NodeAtFrame nodeAtFrame = assureLocalInfo(treePath);
-                if (nodeAtFrame == null) {
-                        return;
-                }
-
-                if (nodeAtFrame.panel == null) {
-                        return;
-                }
-                Node node = TreeNode.tryGetNode(treePath);
-                if (node == null) {
-                        return;
-                }
-                nodeAtFrame.panel.setCurrentTreePath(treePath);
-                nodeAtFrame.panel.pullValuesFromLocalToUser(TreeOperations.bindAccess(node));
-
-                frame.showPanel(nodeAtFrame.panel);
-
-        }
-
-        public void useOrCreatePanel(TreePath treePath) {
-                // node.assureResolved();
-                Node node = TreeNode.tryGetNode(treePath);
-
-                NodeAtFrame nodeAtFrame = assureLocalInfo(treePath);
-
-                if (nodeAtFrame.panel == null) {
-                        CompositeParam param = node.getParam();
-                        nodeAtFrame.panel = findPanel(param.computeAccessId());
-                        if (nodeAtFrame.panel == null) {
-                                FramsClass framsClass = node.getTree().getInfoFromCache(param.getContainedTypeName());
-                                nodeAtFrame.panel = preparePanel(param, framsClass);
-                        }
-                }
-                fillPanelWithValues(treePath);
-        }
 }